Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Unify naming of components that use 'connect' #567

Closed
slaweet opened this issue Aug 7, 2017 · 1 comment
Closed

Unify naming of components that use 'connect' #567

slaweet opened this issue Aug 7, 2017 · 1 comment

Comments

@slaweet
Copy link
Contributor

slaweet commented Aug 7, 2017

Expected behaviour

Often we have two components with a similar name - the real component and the component wrapped with connect. Those two should be named distinctly and consistently.
Research what other projects use and choose one way and use it consistently.

Actual behaviour

Some examples different naming:
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/header/headerElement.js
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/toaster/toasterComponent.js
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/passphrase/passphrase.js

@alepop
Copy link
Contributor

alepop commented Aug 20, 2017

@slaweet in my opinion, components organization should look like :

.
└── components
    └── header
        ├── index.js
        ├── style.css
        └── ...

The index.js exports component and the connected version of component as a deafult.

@slaweet slaweet self-assigned this Aug 24, 2017
reyraa added a commit that referenced this issue Aug 30, 2017
Unify naming of components that use 'connect' - Closes #567
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants