Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Create ActionBar React component #541

Closed
slaweet opened this issue Aug 1, 2017 · 0 comments
Closed

Create ActionBar React component #541

slaweet opened this issue Aug 1, 2017 · 0 comments
Assignees

Comments

@slaweet
Copy link
Contributor

slaweet commented Aug 1, 2017

Expected behaviour

There should be one ActionBar component.
It could look for example like this:

<ActionBar 
  secondaryButton={{
    label: 'Cancel',
    onClick: someFn,
  }}
  primaryButton= {{
    label: 'Vote',
    onClick: someFn,
    disabled: someExpression,
    className: 'vote-button'
  }}
  fee='1'
  />

Actual behaviour

There are multiple action bars, a lot of code repetition:
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/send/send.js#L109-L117
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/signVerify/signMessage.js#L69-L76
https://github.com/LiskHQ/lisk-nano/blob/development/src/components/passphrase/passphrase.js#L63-L74

And more will come.

@slaweet slaweet added the *easy label Aug 1, 2017
@slaweet slaweet self-assigned this Aug 2, 2017
slaweet added a commit that referenced this issue Aug 8, 2017
Create ActionBar React component - Closes #541
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant