Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Unify the test titles #503

Closed
reyraa opened this issue Jul 21, 2017 · 0 comments
Closed

Unify the test titles #503

reyraa opened this issue Jul 21, 2017 · 0 comments
Assignees
@reyraa
Labels
standards test

Comments

@reyraa
Copy link
Contributor

reyraa commented Jul 21, 2017 •
edited by slaweet
Loading

Expected behaviour

  • All titles should be a meaningful sentences if read with 'it'.
  • All should shortly describe the situation of test.
  • Component tests should only contains the name of the component
  • To prevent merging, test in Utils, Actions and other directories should start with the name of directory

Actual behaviour

The titles currently have different formats and some of the don't cover the situation.
Some tests show the name of component with HTML annotations

Steps to reproduce

run npm run test
@reyraa reyraa self-assigned this Jul 21, 2017
@reyraa reyraa mentioned this issue Jul 21, 2017
Merged
reyraa added a commit that referenced this issue Jul 21, 2017
@reyraa
Merge pull request #504 from LiskHQ/503-unify-test-titles
cb0aff7 
Unify test titles - Closes #503
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reyraa reyraa

Labels
standards test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyraa @slaweet