Refactor new passphrase modal into a component #189

slaweet · 2017-05-09T06:12:55Z

Expected behaviour

New passphrase modal should be a separate component so that it can be tested

Actual behaviour

Currently, new passphrase modal is inside a $mdModal
https://github.com/LiskHQ/lisk-nano/blob/development/src/app/components/login/passphrase.js#L27-L65
and it cannot be easily tested

Refactor save passphrase modal into a component - Closes #189

slaweet added refactoring test labels May 9, 2017

reyraa added the *medium label May 9, 2017

slaweet self-assigned this May 30, 2017

slaweet added a commit that referenced this issue May 30, 2017

Refactor save passphrase modal into a component #189

ce7a7bf

slaweet added a commit that referenced this issue May 30, 2017

Refactor save passphrase modal into a component #189

a7f5ee4

slaweet mentioned this issue May 31, 2017

Refactor save passphrase modal into a component - Closes #189 #278

Merged

slaweet closed this as completed in #278 Jun 1, 2017

slaweet added a commit that referenced this issue Jun 1, 2017

Merge pull request #278 from LiskHQ/189-refactor-new-passphrase-modal

5c28a66

Refactor save passphrase modal into a component - Closes #189

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor new passphrase modal into a component #189

Refactor new passphrase modal into a component #189

slaweet commented May 9, 2017

Refactor new passphrase modal into a component #189

Refactor new passphrase modal into a component #189

Comments

slaweet commented May 9, 2017

Expected behaviour

Actual behaviour