Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Make files organisation clearer #154

Closed
slaweet opened this issue Apr 27, 2017 · 0 comments
Closed

Make files organisation clearer #154

slaweet opened this issue Apr 27, 2017 · 0 comments
Assignees
Milestone

Comments

@slaweet
Copy link
Contributor

slaweet commented Apr 27, 2017

Expected behaviour

Some files should be moved and/or renamed, namely:

# adhere to cammelCase
mv src/app/lisk-nano.js src/app/liskNano.js
mv src/app/services/sign-verify.js src/app/services/signVerify.js
mv src/app/components/sign-verify/sign-message.js src/app/components/sign-verify/signMessage.js 
mv src/app/components/sign-verify/sign-message.pug src/app/components/sign-verify/signMessage.pug 
mv src/app/components/sign-verify/verify-message.js src/app/components/verify-verify/verifyMessage.js 
mv src/app/components/sign-verify/verify-message.pug src/app/components/verify-verify/verifyMessage.pug
mv src/app/components/sign-verify/ src/app/components/signVerify/

# this one need to be merged with ./package.json
mv src/package.json ./

# make folder structure cleaner
mv src/app/services/peers/peers.js src/app/services/
rmdir src/app/services/peers/
mv src/app/* src/
rmdir src/app
mv src/test ./test
mv src/spec ./e2e-test

# move conf files to root
mv src/webpack.config.babel.js ./
mv src/karma.conf.js ./
mv src/.eslintrc.json ./

Consequently, all the files that refer to the aforementioned have to be updated.
Also, unit test files cammelCase should be updated accordingly.

Actual behaviour

All files are in their current location

@slaweet slaweet added the chore label Apr 27, 2017
@slaweet slaweet changed the title Make code organization clearer Make files organisation clearer Apr 27, 2017
@karmacoma karmacoma added this to the Version 1.0.0 milestone Apr 27, 2017
slaweet added a commit that referenced this issue May 18, 2017
slaweet added a commit that referenced this issue May 18, 2017
…ation-clearer

Revert "Make files organisation clearer - Resolves #154"
slaweet added a commit that referenced this issue May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants