Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use transaction hook to create and broadcast transaction to network #4720

Closed
Tracked by #4341
reyraa opened this issue Jan 13, 2023 · 1 comment
Closed
Tracked by #4341

Use transaction hook to create and broadcast transaction to network #4720

reyraa opened this issue Jan 13, 2023 · 1 comment
Assignees
@eniolam1000752
Labels
domain: transaction type: refactoring
Milestone
Sprint 92

Comments

@reyraa
Copy link
Contributor

reyraa commented Jan 13, 2023 •
edited
Loading

Description

Following #4718, we should use the updated fee value in composition, signature and broadcasting the transaction. This means we should update all utility functions involved in said actions to adapt to the new fee data.

Acceptance criteria

Users should be able to

  • Sign transactions of any module-commands
  • Dry run said transactions successfully
  • Broadcast said transactions successfully (Changes should be applied)
  • Add relevant unit tests should be updated.
@ManuGowda ManuGowda changed the title Use above hook to create txs and broadcast them Use transaction hook to create and broadcast transaction to network Jan 16, 2023
@ManuGowda ManuGowda mentioned this issue Jan 16, 2023
Closed
@ManuGowda ManuGowda added this to the Sprint 91 milestone Jan 16, 2023
@ManuGowda ManuGowda moved this from Backlog to Todo in Lisk Desktop Version 3.0.0 Jan 17, 2023
@ManuGowda ManuGowda moved this from Todo to In Progress in Lisk Desktop Version 3.0.0 Jan 18, 2023
@sridharmeganathan sridharmeganathan mentioned this issue Jan 31, 2023
Closed
80 tasks
@ManuGowda ManuGowda assigned eniolam1000752 and unassigned reyraa Feb 1, 2023
@ManuGowda
Copy link
Contributor

This issue was working as intended with the completion of #4719

@github-project-automation github-project-automation bot moved this from In Progress to Done in Lisk Desktop Version 3.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eniolam1000752 eniolam1000752

Labels
domain: transaction type: refactoring
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 92
Development

No branches or pull requests
4 participants
@reyraa @ManuGowda @eniolam1000752 @sridharmeganathan