Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt is default application with metadata service #4708

Closed
Tracked by #4341
soroushm opened this issue Jan 11, 2023 · 1 comment
Closed
Tracked by #4341

Adapt is default application with metadata service #4708

soroushm opened this issue Jan 11, 2023 · 1 comment

Comments

@soroushm
Copy link
Contributor

soroushm commented Jan 11, 2023

Description

Since the service behaviour is changed and isDefault argument is now part of the application meta data, this change needs to update

Acceptance Criteria

  • BaseUrl of meta service should be configured in the env
  • Split MetaData Client from application Client in order to always call meta data from the ENV BaseURL
  • First call /api/v3/blockchain/apps with query string of isDefault: true and network Mainnet
  • Fetch the rest of information from api/v3/blockchain and merge it by using transformResult from Client
  • Select first index default application(LISK) check for application status and set the current application with Lisk
  • These logic should be part of custom hooks and used in bootstrap component

Additional Information

#4707

@ikem-legend ikem-legend changed the title Adopt is default application with metadata service Adapt is default application with metadata service Jan 16, 2023
@ManuGowda ManuGowda added this to the Sprint 91 milestone Jan 16, 2023
@soroushm soroushm self-assigned this Jan 19, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Feb 2, 2023
@soroushm soroushm reopened this Feb 7, 2023
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 91, Sprint 93 Feb 7, 2023
@soroushm soroushm assigned eniolam1000752 and unassigned soroushm Feb 15, 2023
@ManuGowda
Copy link
Contributor

ManuGowda commented Feb 15, 2023

With regards to environment configurations, we should consider the following:

Lisk supports following networks, devnet, alphanet, betanet, testnet and mainnet. for all of these Lisk Service provides following URLs:

https://devnet-service.lisk.com
https://alphanet-service.lisk.com
https://betanet-service.lisk.com
https://testnet-service.lisk.com
https://mainnet-service.lisk.com

Based on the above base URL we can fetch application metadata and corresponding application specific service URLs.

So in env config file, we should use appropriate network name e.g devnet during development, alphanet once we tag alpha and release it for testing, betanet once we tag beta and release it for testing, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants