Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to sign transactions originated from wallet connect application #4623

Closed
Tracked by #4341
ManuGowda opened this issue Dec 2, 2022 · 0 comments
Closed
Tracked by #4341

Unable to sign transactions originated from wallet connect application #4623

ManuGowda opened this issue Dec 2, 2022 · 0 comments
Assignees
@reyraa
Labels
domain: transaction domain: wallet-connect type: bug
Milestone
Sprint 93

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

Users should be able to sign transactions originated from wallet connect application

Actual behavior

Unable to sign transactions originated from wallet connect application, migrate old transaction composing and signing logic

lisk-desktop/src/modules/blockchainApplication/connection/components/RequestSummary/index.js

Line 54 in a47fdcc

rawTx: {

Steps to reproduce

  • Initiate transaction to be signed from blockchain application which has wallet connect support

Which version(s) does this affect? (Environment, OS, etc...)

v3
@sridharmeganathan sridharmeganathan added this to the Sprint 90 milestone Jan 2, 2023
@sridharmeganathan sridharmeganathan mentioned this issue Jan 3, 2023
Closed
80 tasks
@ManuGowda ManuGowda modified the milestones: Sprint 90, Sprint 91 Jan 16, 2023
@sridharmeganathan sridharmeganathan added this to the Sprint 93 milestone Feb 13, 2023
@reyraa reyraa mentioned this issue Feb 20, 2023
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
domain: transaction domain: wallet-connect type: bug
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 93
Development

When branches are created from issues, their pull requests are automatically linked.

4623-unable-to-sign-transactions LiskHQ/lisk-desktop
4 participants
@reyraa @soroushm @ManuGowda @sridharmeganathan