Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review dependencies and dev dependencies #4609

Closed
Tracked by #4341
soroushm opened this issue Nov 25, 2022 · 0 comments · Fixed by #4610
Closed
Tracked by #4341

Review dependencies and dev dependencies #4609

soroushm opened this issue Nov 25, 2022 · 0 comments · Fixed by #4610
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@soroushm
Copy link
Contributor

Description

Currently we have following dependencies and dev dependencies.

We need to review the following dependencies and reduce the usage if not required to:

  • To reduce the unwanted dependencies
  • Maintainability
  "dependencies": {
    "@electron/universal": "1.1.0",
    "@hirishh/lisk-ledger.js": "2.2.0",
    "@hookform/resolvers": "2.8.8",
    "@ledgerhq/hw-transport": "6.3.0",
    "@ledgerhq/hw-transport-node-hid": "6.6.0",
    "@liskhq/lisk-client": "5.2.1",
    "@testing-library/react-hooks": "5.1.2",
    "await-to-js": "2.1.1",
    "bignumber.js": "8.0.1",
    "bip32": "1.0.4",
    "bitcore-lib": "8.25.10",
    "bitcore-mnemonic": "8.25.25",
    "blake2b": "2.1.4",
    "body-parser": "1.18.3",
    "browser-or-node": "1.1.0",
    "chart.js": "2.9.4",
    "cheerio": "1.0.0-rc.10",
    "core-js": "3.11.0",
    "crypto-browserify": "^3.12.0",
    "electron-localshortcut": "3.2.1",
    "electron-store": "8.0.0",
    "enzyme-adapter-react-16": "1.15.6",
    "express": "4.16.4",
    "flexboxgrid": "=6.3.1",
    "flexboxgrid-helpers": "1.1.3",
    "get-port": "4.1.0",
    "hard-source-webpack-plugin": "0.13.1",
    "history": "=4.7.2",
    "html-entities": "1.4.0",
    "i18next": "17.0.16",
    "is-electron": "2.2.0",
    "js-sha256": "0.9.0",
    "jspdf": "2.3.1",
    "jsx-to-string": "1.4.0",
    "leaflet": "1.6.0",
    "leaflet.markercluster": "1.5.0",
    "lodash.debounce": "4.0.8",
    "lodash.merge": "4.6.2",
    "lodash.throttle": "4.1.1",
    "lottie-web": "5.5.5",
    "moment": "2.23.0",
    "node-abi": "3.8.0",
    "node-hid": "2.1.1",
    "numeral": "git+https://github.com/LiskHQ/Numeral-js.git",
    "path-browserify": "^1.0.1",
    "postcss": "8.2.13",
    "prop-types": "15.7.2",
    "qrcode.react": "1.0.1",
    "react": "16.14.0",
    "react-chartjs-2": "=2.8.0",
    "react-copy-to-clipboard": "5.0.3",
    "react-countdown": "2.2.1",
    "react-dom": "16.14.0",
    "react-fast-compare": "2.0.4",
    "react-highlight-words": "0.17.0",
    "react-hook-form": "7.31.1",
    "react-i18next": "10.12.5",
    "react-json-view": "^1.21.3",
    "react-piwik": "1.6.0",
    "react-redux": "7.2.4",
    "react-router": "5.0.1",
    "react-router-dom": "5.0.1",
    "react-string-replace": "0.4.4",
    "react-toastify": "5.5.0",
    "react-waypoint": "9.0.3",
    "redux": "4.0.1",
    "redux-persist": "6.0.0",
    "redux-thunk": "2.3.0",
    "socket.io-client": "2.2.0",
    "stream-browserify": "2.0.2",
    "trezor-connect": "8.1.26",
    "trezor.js": "9.3.4",
    "usb": "1.7.0",
    "webpack-merge": "=4.1.5",
    "yup": "0.32.11"
  },
  "devDependencies": {
    "@babel/core": "7.13.16",
    "@babel/plugin-proposal-nullish-coalescing-operator": "7.13.8",
    "@babel/plugin-proposal-optional-chaining": "7.13.12",
    "@babel/plugin-syntax-import-meta": "7.10.4",
    "@babel/plugin-transform-runtime": "7.13.15",
    "@babel/preset-env": "7.13.15",
    "@babel/preset-react": "7.13.13",
    "@percy/storybook": "3.3.1",
    "@storybook/addon-actions": "6.2.9",
    "@storybook/addon-links": "6.2.9",
    "@storybook/react": "6.2.9",
    "@testing-library/dom": "8.13.0",
    "@testing-library/jest-dom": "5.16.4",
    "@testing-library/react": "12.1.2",
    "@welldone-software/why-did-you-render": "6.1.1",
    "babel-eslint": "10.0.1",
    "babel-jest": "24.9.0",
    "babel-loader": "8.0.6",
    "babel-plugin-import-glob": "=2.0.0",
    "babel-plugin-syntax-trailing-function-commas": "=6.22.0",
    "babel-plugin-transform-class-properties": "6.24.1",
    "chai": "4.2.0",
    "chai-as-promised": "7.1.1",
    "chai-enzyme": "1.0.0-beta.1",
    "cpx": "1.5.0",
    "cross-env": "7.0.3",
    "css-loader": "5.2.4",
    "cypress": "8.7.0",
    "cypress-cucumber-preprocessor": "4.3.0",
    "cypress-failed-log": "2.9.2",
    "cypress-pipe": "2.0.0",
    "cypress-terminal-report": "3.4.1",
    "electron": "17.0.0",
    "electron-builder": "23.0.2",
    "electron-builder-notarize": "1.4.0",
    "electron-devtools-installer": "3.2.0",
    "electron-ipc-mock": "0.0.3",
    "electron-rebuild": "3.2.7",
    "electron-updater": "4.3.8",
    "enzyme": "3.10.0",
    "eslint": "7.21.0",
    "eslint-config-airbnb": "18.2.1",
    "eslint-import-resolver-alias": "1.1.2",
    "eslint-plugin-babel": "5.3.0",
    "eslint-plugin-cypress": "2.1.2",
    "eslint-plugin-import": "2.22.1",
    "eslint-plugin-jest": "22.1.2",
    "eslint-plugin-jsx-a11y": "6.4.1",
    "eslint-plugin-react": "7.23.2",
    "eslint-webpack-plugin": "2.5.2",
    "file-loader": "6.2.0",
    "glob": "7.1.3",
    "html-webpack-plugin": "5.2.0",
    "i18next-scanner": "3.0.0",
    "identity-obj-proxy": "3.0.0",
    "inline-chunk-html-plugin": "1.1.1",
    "jest": "26.6.3",
    "jest-canvas-mock": "2.0.0",
    "jest-date-mock": "1.0.7",
    "jest-enzyme": "7.1.1",
    "jest-junit": "10.0.0",
    "jest-localstorage-mock": "2.3.0",
    "jest-watch-toggle-config": "1.0.2",
    "jest-watch-typeahead": "0.4.0",
    "mini-css-extract-plugin": "1.3.9",
    "npm-run-all": "4.1.5",
    "postcss-for": "=2.1.1",
    "postcss-functions": "3.0.0",
    "postcss-loader": "3.0.0",
    "postcss-mixins": "6.2.1",
    "postcss-nesting": "7.0.0",
    "postcss-partial-import": "=4.1.0",
    "postcss-preset-env": "6.7.0",
    "react-hot-loader": "4.13.0",
    "redux-mock-store": "1.5.3",
    "sinon": "8.1.1",
    "sinon-chai": "3.4.0",
    "sinon-stub-promise": "=4.0.0",
    "stylelint": "13.11.0",
    "stylelint-config-standard": "20.0.0",
    "stylelint-webpack-plugin": "2.1.1",
    "terser-webpack-plugin": "5.1.1",
    "url-loader": "4.1.1",
    "webpack": "5.24.2",
    "webpack-bundle-analyzer": "3.3.2",
    "webpack-cli": "^4.2.0",
    "webpack-dev-server": "3.11.2"
  }

Acceptance Criteria

  • remove unused package
  • move dev dependencies
  • test application
  • test application pack (electron build)
@soroushm soroushm self-assigned this Nov 25, 2022
@soroushm soroushm added the dependencies Pull requests that update a dependency file label Nov 25, 2022
@soroushm soroushm added this to the Sprint 88 milestone Nov 25, 2022
Repository owner moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants