Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt transaction push update and invalid query cache #4525

Closed
Tracked by #4341
soroushm opened this issue Oct 20, 2022 · 0 comments · Fixed by #4626
Closed
Tracked by #4341

Adopt transaction push update and invalid query cache #4525

soroushm opened this issue Oct 20, 2022 · 0 comments · Fixed by #4626

Comments

@soroushm
Copy link
Contributor

soroushm commented Oct 20, 2022

Description

On broadcasting a transaction, it's going to the transaction pool and submitting the transaction to network. Wallet will receive the transaction by subscription to the web socket channel. At the moment, several of the cache needs to be updated or invalidated

Acceptance Criteria

  • Subscribe to transaction channel 'new.transactions', 'delete.transactions'
  • Update Transaction history (follow the logic to show new event button on query table)
  • Invalidate auth cache
  • Add notification for when current account receives tokens. It should look like new Notification(i18n.t('{{amount}} {{token}} Received', { amount, token }), { body: i18n.t('Your account just received {{amount}} {{token}} {{message}}', { amount, token, message }), });

Additional Information

  • After broadcast, keep transaction details in React Context
  • In web socket push data, we need to merge the transaction cache with the new transaction found
  • Remove the transaction details in React Context
@sridharmeganathan sridharmeganathan added this to the Sprint 88 milestone Nov 22, 2022
@ikem-legend ikem-legend self-assigned this Nov 30, 2022
Repository owner moved this from Backlog to Done in Lisk Desktop Version 3.0.0 Dec 20, 2022
@ManuGowda ManuGowda changed the title Adopt Transaction push update and invalid query cache Adopt transaction push update and invalid query cache Dec 20, 2022
@ManuGowda ManuGowda modified the milestones: Sprint 88, Spike 4 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants