Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update minFee computation #1310

Closed
sameersubudhi opened this issue Oct 20, 2022 · 0 comments · Fixed by #1332
Closed

Update minFee computation #1310

sameersubudhi opened this issue Oct 20, 2022 · 0 comments · Fixed by #1332
Assignees
@priojeetpriyom
Labels
service/blockchain-connector type: improvement
Milestone
Sprint 68

Comments

@sameersubudhi
Copy link
Contributor

sameersubudhi commented Oct 20, 2022 •
edited by priojeetpriyom
Loading

Description

The extra fees (name fee, delegate registration fees etc.) is currently part of the transaction params (property varying by command). However, in the future it is planned to be added to the transaction fee (like before). This requires properly re-calculating the transaction minFee implementation within the lisk-connector.

Acceptance Criteria

  • decodeTransaction in services/blockchain-connector/shared/sdk/decoder.js is updated to compute the values properly
  • Functional tests are added / up-to-date

Additional Information
@sridharmeganathan sridharmeganathan added this to the Sprint 67 milestone Nov 8, 2022
@sridharmeganathan sridharmeganathan mentioned this issue Nov 8, 2022
Closed
@priojeetpriyom priojeetpriyom self-assigned this Nov 15, 2022
@priojeetpriyom priojeetpriyom moved this from Backlog to In Progress in Lisk Service Version 0.7.0 Nov 15, 2022
@priojeetpriyom priojeetpriyom mentioned this issue Nov 17, 2022
Merged
5 tasks
Repository owner moved this from In Progress to Done in Lisk Service Version 0.7.0 Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@priojeetpriyom priojeetpriyom

Labels
service/blockchain-connector type: improvement
Projects
None yet
Milestone
Sprint 68
Development

Successfully merging a pull request may close this issue.

Update minFee computation LiskArchive/lisk-service
3 participants
@priojeetpriyom @sameersubudhi @sridharmeganathan