Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update verify logic in authority module update authority command #8929

Closed
Tracked by #7245
mitsuaki-u opened this issue Sep 4, 2023 · 0 comments · Fixed by #8953
Closed
Tracked by #7245

Update verify logic in authority module update authority command #8929

mitsuaki-u opened this issue Sep 4, 2023 · 0 comments · Fixed by #8953
Assignees
Milestone

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Sep 4, 2023

Expected behavior

Verify hook in update authority command should have proper schema and checks

Actual behavior

  • Validator length check can be done in schema.
  • totalWeight === 0 check missing
  • Validator weight cannot be 0

Steps to reproduce

Check verify hook logic

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants