Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Throw error from getAuthAccount when account doesn't exist #8843

Closed
Tracked by #7226
ishantiw opened this issue Aug 11, 2023 · 1 comment
Closed
Tracked by #7226

Throw error from getAuthAccount when account doesn't exist #8843

ishantiw opened this issue Aug 11, 2023 · 1 comment
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

Description

The getAuthAccount method implementation differs from LIP-0041. The LIP says the implementation should raise an exception when no account exists. The implementation returns a default account when no account exists.

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-beta.6

@bobanm
Copy link
Contributor

bobanm commented Aug 14, 2023

As agreed with @shuse2, in this case it makes more sense to keep the implementation as it is, and align the LIP. That would align behavior of getAuthAccount() with behavior of getAvailableBalance() and getEscrowedAmount(), where LIP-0051 specifies that for a non-existing key the system should return 0 as the default value.

I opened the issue in LIP repo.

@bobanm bobanm closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@Madhulearn Madhulearn added this to the Sprint 102 milestone Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants