Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Check that the idxs are strictly increasing in message recovery verify #8723

Closed
Tracked by #7226
ishantiw opened this issue Jul 11, 2023 · 1 comment · Fixed by #8814
Closed
Tracked by #7226

Check that the idxs are strictly increasing in message recovery verify #8723

ishantiw opened this issue Jul 11, 2023 · 1 comment · Fixed by #8814
Assignees
@ishantiw
Labels
framework/module/interoperability Interoperability module
Milestone
Sprint 101

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jul 11, 2023 •
edited
Loading

Description

Update message recovery execution to emit EVENT_NAME_INVALID_RMT_VERIFICATION in execution

  • Move RMT verification to execute
  • Introduce new checks to verify

Acceptance Criteria

  • Should have a unit test related to this change

Additional Information

Related LIP https://github.com/LiskHQ/lips/blob/c1532dc9787a792cce0b5c722caa03b9204b927f/proposals/lip-0054.md#execution-1
@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Jul 11, 2023
@ishantiw ishantiw mentioned this issue Jul 11, 2023
Merged
@AndreasKendziorra
Copy link
Contributor

While fixing this, you may also consider this LIP change. It does not change the behavior but makes the verification slightly more efficient.

@ishantiw ishantiw mentioned this issue Jul 19, 2023
Closed
@Madhulearn Madhulearn added this to the Sprint 101 milestone Aug 1, 2023
@ishantiw ishantiw self-assigned this Aug 3, 2023
@ishantiw ishantiw mentioned this issue Aug 7, 2023
Merged
@ishantiw ishantiw changed the title Update Message Recovery Command to emit RMT verify failed event Check that the idxs are strictly increasing in message recovery verify Aug 10, 2023
@ishantiw ishantiw linked a pull request Aug 11, 2023 that will close this issue
Update message recovery #8814
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
framework/module/interoperability Interoperability module
Projects
None yet
Milestone
Sprint 101
Development

Successfully merging a pull request may close this issue.

Update message recovery LiskArchive/lisk-sdk
3 participants
@ishantiw @AndreasKendziorra @Madhulearn