Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Duplicate constants for Lisk32 charset #8653

Closed
Tracked by #7226
ishantiw opened this issue Jun 23, 2023 · 1 comment
Closed
Tracked by #7226

Duplicate constants for Lisk32 charset #8653

ishantiw opened this issue Jun 23, 2023 · 1 comment
Assignees
@bobanm
Labels
framework type: improvement
Milestone
Sprint 100

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jun 23, 2023 •
edited
Loading

Description

The CHARSET and LISK32_CHARSET constants are equivalent and are both used in the same set of functions for validation and encoding/decoding Lisk32 addresses. The code should be simplified to define and use only one constant for the valid set of characters.

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-beta.2
@ishantiw ishantiw mentioned this issue Jun 28, 2023
Closed
@bobanm
Copy link
Contributor

bobanm commented Jul 4, 2023

I have addressed this on my own initiative in draft PR #7928

Can we close this issue as a duplicate of #7927, and assign that issue to sprint?

@bobanm bobanm self-assigned this Jul 4, 2023
@Madhulearn Madhulearn added this to the Sprint 100 milestone Jul 18, 2023
@bobanm bobanm mentioned this issue Jul 25, 2023
Merged
@shuse2 shuse2 closed this as completed Jul 27, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobanm bobanm

Labels
framework type: improvement
Projects
None yet
Milestone
Sprint 100
Development

No branches or pull requests
4 participants
@shuse2 @bobanm @ishantiw @Madhulearn