You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
The BaseCCChannelTerminatedCommand command does not validate the status of the incoming CCM. This means that, if a CCM of this type is bounced, the command will try to add the sending chain that bounced the request to the TerminatedStateStore.
In this command, this does not pose a major problem. If the chain sent this CCM to the target chain, it likely already terminated the target chain in the first plane. However, in other cases not verifying the status may be problematic.
Recommendation
check the status of the CCM in the BaseCCChannelTerminatedCommand verify method, and only process the request if the status is OK.
Acceptance Criteria
v6.0.0-beta.2
The text was updated successfully, but these errors were encountered:
Description
The
BaseCCChannelTerminatedCommand
command does not validate the status of the incomingCCM
. This means that, if aCCM
of this type is bounced, the command will try to add the sending chain that bounced the request to the TerminatedStateStore.In this command, this does not pose a major problem. If the chain sent this
CCM
to the target chain, it likely already terminated the target chain in the first plane. However, in other cases not verifying the status may be problematic.Recommendation
check the
status
of theCCM
in theBaseCCChannelTerminatedCommand
verify method, and only process the request if the status isOK
.Acceptance Criteria
v6.0.0-beta.2
The text was updated successfully, but these errors were encountered: