Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

The Channel Terminated Command does not validate the CCM status #8608

Closed
Tracked by #7226
ishantiw opened this issue Jun 16, 2023 · 0 comments · Fixed by #8713
Closed
Tracked by #7226

The Channel Terminated Command does not validate the CCM status #8608

ishantiw opened this issue Jun 16, 2023 · 0 comments · Fixed by #8713
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

Description

The BaseCCChannelTerminatedCommand command does not validate the status of the incoming CCM. This means that, if a CCM of this type is bounced, the command will try to add the sending chain that bounced the request to the TerminatedStateStore.
In this command, this does not pose a major problem. If the chain sent this CCM to the target chain, it likely already terminated the target chain in the first plane. However, in other cases not verifying the status may be problematic.

Recommendation
check the status of the CCM in the BaseCCChannelTerminatedCommand verify method, and only process the request if the status is OK.

Acceptance Criteria

v6.0.0-beta.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants