Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing tests in sidechain CCU update command #7998

Closed
Tracked by #7245
mitsuaki-u opened this issue Jan 12, 2023 · 1 comment
Closed
Tracked by #7245

Missing tests in sidechain CCU update command #7998

mitsuaki-u opened this issue Jan 12, 2023 · 1 comment
Assignees
Milestone

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Jan 12, 2023

Expected behavior

Should be complete test coverage

Actual behavior

Missing tests:

verify:

  • Update params validation test to use context creation utility function and check for throw
  • if len(certificateBytes) == 0 and ccu.params.inboxUpdate is empty should throw
  • if chainAccount(ccu.params.sendingChainID) does not exist should throw
  • if len(validatorsUpdate.blsKeysUpdate) > 0 or len(validatorsUpdate.bftWeightsUpdate) > 0 or validatorsUpdate.bftWeightsUpdateBitmap != EMPTY_BYTES or ccu.params.certificateThreshold != validators(ccu.params.sendingChainID).certificateThreshold should call veriftValidatorsUpdate(ccu)

execute:

  • Update the context to indicate that now we stop the CCM processing.
    ctx.ccmProcessing = False
    (double check if this is done differently in the code through events or another method)

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

development

@sitetester
Copy link
Contributor

sitetester commented Sep 18, 2023

This issue is mostly superseded by recent changes in #8840 when verifyCommon method was updated in relevant LIP.

Also since LIP 53 has updated lately, those changes are planning to be addressed in #9009

@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 Sep 19, 2023
@Madhulearn Madhulearn moved this from Done to In Progress in Lisk SDK Version 6.0.0 Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants