Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add missing unit tests for the PoS Module Genesis Processing #7898

Closed
Tracked by #7244
mosmartin opened this issue Dec 15, 2022 · 2 comments
Closed
Tracked by #7244

Add missing unit tests for the PoS Module Genesis Processing #7898

mosmartin opened this issue Dec 15, 2022 · 2 comments
Assignees
@mosmartin
Labels
framework
Milestone
Sprint 95

Comments

@mosmartin
Copy link
Contributor

mosmartin commented Dec 15, 2022 •
edited
Loading

Description

Based on the defined test cases, the following tests are missing from the implemented unit tests.

  • When genesis block initDelegates contains more delegates than round length
    • Expectation: Genesis block should be rejected
  • When genesis block initDelegates contains an address which is not a delegate account
    • Expectation: Genesis block should be rejected

Motivation

These test will align with defined test cases and ensure complete coverage of the scenarios.
@ishantiw ishantiw moved this to Backlog in Lisk SDK Version 6.0.0 Dec 19, 2022
@Madhulearn Madhulearn added this to the Sprint 85 milestone Dec 19, 2022
@Madhulearn Madhulearn modified the milestones: Sprint 85, Sprint 86 Jan 3, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 86, Sprint 87 Jan 17, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 87, Sprint 88 Jan 30, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 88, Sprint 89 Feb 13, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 89, Sprint 90 Feb 28, 2023
@shuse2 shuse2 removed this from the Sprint 90 milestone Mar 2, 2023
@Madhulearn Madhulearn added this to the Sprint 94 milestone Apr 24, 2023
@Madhulearn Madhulearn mentioned this issue Apr 24, 2023
Closed
@mosmartin mosmartin self-assigned this Apr 25, 2023
@mosmartin
Copy link
Contributor Author

For the second test, When genesis block initDelegates contains an address which is not a delegate account scenario, it's been included in the invalidAssets sent stake validator address is not validator test.

@mosmartin mosmartin mentioned this issue May 4, 2023
Closed
@Madhulearn Madhulearn modified the milestones: Sprint 94, Sprint 95 May 9, 2023
@mosmartin
Copy link
Contributor Author

The above issues are already addressed.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Lisk SDK Version 6.0.0 May 15, 2023
@shuse2 shuse2 mentioned this issue Jun 28, 2023
Closed
25 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mosmartin mosmartin

Labels
framework
Projects
None yet
Milestone
Sprint 95
Development

Successfully merging a pull request may close this issue.

Add missing unit tests for the PoS Module Genesis Processing LiskArchive/lisk-sdk
4 participants
@shuse2 @ishantiw @mosmartin @Madhulearn