You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Testing event emission if tokenID is not available.
Testing event emission if tokenID is not native.
mint
Perhaps the test case should reject if supply exceed max balance should be rephrased to be clearer.
burn
Argument validation missing.
No change necessary.
initializeUserAccount
Error scenarios do not verify event emission.
There are no events in case of error, no change necessary.
initializeEscrowAccount
Error scenarios do not verify event emission.
There are no events in case of error, no changes necessary.
transfer
Should throw error and log event if recipient is not initialized however, current implementation initializes the recipient account.
The implementation is aligned with the LIP and no change is required.
transferCrosschain
Should throw error and log event if escrow account does not exist, however, current implementation initializes non-existent escrow account.
Implementation is aligned with the LIP and no change is required.
supportAllTokensFromChainID
Tests rely on calls to SupportedTokensStore, introspective testing can be improved.
removeAllTokensSupportFromChainID
Tests rely on calls to SupportedTokensStore, introspective testing can be improved.
supportTokenID
Tests rely on calls to SupportedTokensStore, introspective testing can be improved.
removeSupportTokenID
Tests rely on calls to SupportedTokensStore, introspective testing can be improved.
The text was updated successfully, but these errors were encountered:
getNextAvailableTokenID
Implementation missing.
isTokenIDAvailable
All test cases missing.
initializeToken
mint
should reject if supply exceed max balance
should be rephrased to be clearer.burn
Argument validation missing.No change necessary.
initializeUserAccount
Error scenarios do not verify event emission.There are no events in case of error, no change necessary.
initializeEscrowAccount
Error scenarios do not verify event emission.There are no events in case of error, no changes necessary.
transfer
Should throw error and log event if recipient is not initialized however, current implementation initializes the recipient account.The implementation is aligned with the LIP and no change is required.
transferCrosschain
Should throw error and log event if escrow account does not exist, however, current implementation initializes non-existent escrow account.Implementation is aligned with the LIP and no change is required.
supportAllTokensFromChainID
SupportedTokensStore
, introspective testing can be improved.removeAllTokensSupportFromChainID
SupportedTokensStore
, introspective testing can be improved.supportTokenID
SupportedTokensStore
, introspective testing can be improved.removeSupportTokenID
SupportedTokensStore
, introspective testing can be improved.The text was updated successfully, but these errors were encountered: