Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing test cases for Token Methods #7839

Closed
Tracked by #7244
has5aan opened this issue Nov 30, 2022 · 0 comments · Fixed by #8406
Closed
Tracked by #7244

Missing test cases for Token Methods #7839

has5aan opened this issue Nov 30, 2022 · 0 comments · Fixed by #8406
Assignees
Milestone

Comments

@has5aan
Copy link
Contributor

has5aan commented Nov 30, 2022

getNextAvailableTokenID

Implementation missing.

isTokenIDAvailable

All test cases missing.

initializeToken

  • Testing event emission if tokenID is not available.
  • Testing event emission if tokenID is not native.

mint

  • Perhaps the test case should reject if supply exceed max balance should be rephrased to be clearer.

burn

  • Argument validation missing.
    No change necessary.

initializeUserAccount

  • Error scenarios do not verify event emission.
    There are no events in case of error, no change necessary.

initializeEscrowAccount

  • Error scenarios do not verify event emission.
    There are no events in case of error, no changes necessary.

transfer

  • Should throw error and log event if recipient is not initialized however, current implementation initializes the recipient account.
    The implementation is aligned with the LIP and no change is required.

transferCrosschain

  • Should throw error and log event if escrow account does not exist, however, current implementation initializes non-existent escrow account.
    Implementation is aligned with the LIP and no change is required.

supportAllTokensFromChainID

  • Tests rely on calls to SupportedTokensStore, introspective testing can be improved.

removeAllTokensSupportFromChainID

  • Tests rely on calls to SupportedTokensStore, introspective testing can be improved.

supportTokenID

  • Tests rely on calls to SupportedTokensStore, introspective testing can be improved.

removeSupportTokenID

  • Tests rely on calls to SupportedTokensStore, introspective testing can be improved.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants