Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add new integration tests for RandomAPI #7263

Closed
Tracked by #7246
has5aan opened this issue Jun 28, 2022 · 1 comment
Closed
Tracked by #7246

Add new integration tests for RandomAPI #7263

has5aan opened this issue Jun 28, 2022 · 1 comment
Assignees
Milestone

Comments

@has5aan
Copy link
Contributor

has5aan commented Jun 28, 2022

Description

Following modules are dependent on RandomAPI and make a good candidate for integration tests.

Modules dependent on RandomAPI

  • DPoSModule

DPoSModule

  • DPoSModule.afterTransactionsExecute consumes RandomAPI.getRandomBytes

Which version(s) does this affect? (Environment, OS, etc...)

Lisk SDK development branch.

@Madhulearn Madhulearn added this to the Sprint 85 milestone Dec 19, 2022
@Madhulearn Madhulearn modified the milestones: Sprint 85, Sprint 86 Jan 3, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 86, Sprint 87 Jan 17, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 87, Sprint 88 Jan 30, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 88, Sprint 89 Feb 13, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 89, Sprint 90 Feb 28, 2023
@shuse2 shuse2 removed this from the Sprint 90 milestone Mar 2, 2023
@Madhulearn Madhulearn added this to the Sprint 94 milestone Apr 24, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 94, Sprint 95 May 9, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 95, Sprint 96 May 22, 2023
@Madhulearn Madhulearn added this to the Sprint 109 milestone Nov 21, 2023
@has5aan
Copy link
Contributor Author

has5aan commented Nov 28, 2023

The test improvement suggested by the issue for PosModule consuming RandomMethod would require implementation of integration tests for the each PosModule which doesn't serve practically effective improvements based on the recent improvements activity for unit tests around each module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants