Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Delegate search results can be duplicated on local dev #667

Closed
chauey opened this issue Aug 28, 2017 · 4 comments
Closed

Delegate search results can be duplicated on local dev #667

chauey opened this issue Aug 28, 2017 · 4 comments
Labels

Comments

@chauey
Copy link

chauey commented Aug 28, 2017

Expected behaviour

When searching for delegates, should never have duplicates in prod or dev

Actual behaviour

In dev in chrome, am able to get duplicate results, like 2 rows with "thepool" in it. Could be a async problem? maybe using redux and not cancelling previous call when next debounce fires? haven't looked at the codes.

Steps to reproduce

run locally on dev, type in "thepool" and delete the "l" and type it back at varying speeds to get some perhaps edge hard-to-reproduce case. was not able to reproduce yet in the released version. But would want to fix the dev version to be sure it doesn't happen in prod.

image

@slaweet slaweet added the bug label Aug 28, 2017
@slaweet
Copy link
Contributor

slaweet commented Aug 28, 2017

Thank you @chauey for reporting this issue.
What exact git revision did this happen on?
I tried to reproduce it on development branch today with no success. I can see from the screenshot, that it is a bit older, as there are missing the css shadows that were fixed by this PR 4 days ago #648

@chauey
Copy link
Author

chauey commented Aug 28, 2017

I believe I had just forked the repo and was on development. Last commit was on 22nd in there?
image
5363467
uncommitted changes in pix is just package-lock.json file.
I also noticed the odd style issues running in local dev local but not familiar enough if that was to be expected or not.

@chauey
Copy link
Author

chauey commented Aug 28, 2017

perhaps i have old version and need to rebase/refresh or something, i dno't see those css updates. sorry.

@chauey
Copy link
Author

chauey commented Aug 28, 2017

i rebased and got latest and can't reproduce. please feel free to close. sry, thx

@slaweet slaweet added invalid and removed bug labels Aug 29, 2017
@slaweet slaweet closed this as completed Aug 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants