Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Unify angular service naming #179

Closed
slaweet opened this issue May 5, 2017 · 1 comment
Closed

Unify angular service naming #179

slaweet opened this issue May 5, 2017 · 1 comment

Comments

@slaweet
Copy link
Contributor

slaweet commented May 5, 2017

Expected behaviour

Research the best practices for angular service naming and update our code accordingly to make the naming consistent.

Actual behaviour

We have all sorts of naming (UpperCamelCase, camelCase, $camelCase):

Account        
dialog
passphrase
signVerify
delegateService
lsk
$peers
@slaweet slaweet added this to the Version 1.0.0 milestone May 5, 2017
@slaweet slaweet self-assigned this May 8, 2017
@slaweet
Copy link
Contributor Author

slaweet commented May 8, 2017

While the services are updated, we can also look at the methods they offer and fix if parameters are unclear (e.g. param called options) or the method belongs to another service (getDelegate in forgingService).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants