Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Create a modal that can compile any child component #163

Closed
reyraa opened this issue May 2, 2017 · 2 comments
Closed

Create a modal that can compile any child component #163

reyraa opened this issue May 2, 2017 · 2 comments
Labels
*medium refactoring

Comments

@reyraa
Copy link
Contributor

reyraa commented May 2, 2017

Expected behaviour

We want to have a modal component of any type, which uses mdDialog to show/hide a child component. the child component can be any component provided using the constructor.

Actual behaviour

We are using modals along with the modal content in a single component which is not DRY.

Steps to reproduce

These compound components are some examples of non-DRY implementation:

  • /components/login
    • save
    • passphrase
  • /components/main
    • setSecondPass
  • /components/send
    • sendModal
@slaweet slaweet changed the title Create a modal than can compile any child component Create a modal that can compile any child component May 8, 2017
@slaweet
Copy link
Contributor

slaweet commented May 29, 2017

There was an attempt to do this here: https://github.com/LiskHQ/lisk-nano/blob/development/src/services/dialog.js#L95-L111
But it's not finalised and not used anywhere.

@yasharAyari yasharAyari self-assigned this May 29, 2017
@slaweet
Copy link
Contributor

slaweet commented Jul 19, 2017

Done looong time ago in #308

@slaweet slaweet closed this as completed Jul 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*medium refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karmacoma @reyraa @slaweet @yasharAyari