Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set a store as readonly #269

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

LinuxSuRen
Copy link
Owner

@LinuxSuRen LinuxSuRen commented Nov 11, 2023

See the following changes:

  • Add backend e2e for MySQL, MariaDB, Etcd, and git
  • For read-only (for instance, no username or password of git store), the UI page does not allow editing
  • Support to filter the API response JSON via JSON path

Copy link

github-actions bot commented Nov 11, 2023

There are 21 test cases:

API Average Max Min Count Error
gRPC 127.0.0.1:7070/server.Runner/FunctionsQueryStream 5.078139ms 5.825021ms 4.29089ms 3 0
gRPC 127.0.0.1:7070/server.Runner/GetVersion 3.857814ms 7.554558ms 1.141824ms 3 0
POST http://localhost:8080/server.Runner/GetStores 3.82108ms 3.82108ms 3.82108ms 1 0
POST http://localhost:8080/server.Runner/GenerateCode 3.689977ms 3.689977ms 3.689977ms 1 0
POST http://localhost:8080/server.Runner/CreateTestSuite 2.749758ms 2.749758ms 2.749758ms 1 0
gRPC 127.0.0.1:7070/server.Runner/FunctionsQuery 2.205646ms 2.615655ms 1.577333ms 3 0
POST http://localhost:8080/server.Runner/FunctionsQuery 2.129644ms 2.129644ms 2.129644ms 1 0
POST http://localhost:8080/server.Runner/PopularHeaders 1.855839ms 1.855839ms 1.855839ms 1 0
POST http://localhost:8080/server.Runner/ListTestCase 1.581333ms 1.718636ms 1.44403ms 2 0
POST http://localhost:8080/server.Runner/GetTestSuite 1.575933ms 1.575933ms 1.575933ms 1 0
POST http://localhost:8080/server.Runner/ConvertTestSuite 1.570433ms 1.570433ms 1.570433ms 1 0
POST http://localhost:8080/server.Runner/GetTestCase 1.514931ms 1.514931ms 1.514931ms 1 0
POST http://localhost:8080/server.Runner/UpdateTestSuite 1.382529ms 1.382529ms 1.382529ms 1 0
POST http://localhost:8080/server.Runner/DeleteTestSuite 1.273676ms 1.870639ms 676.714µs 2 0
POST http://localhost:8080/server.Runner/GetSuites 1.115023ms 1.115023ms 1.115023ms 1 0
POST http://localhost:8080/server.Runner/GetSuggestedAPIs 1.090923ms 1.090923ms 1.090923ms 1 0
POST http://localhost:8080/server.Runner/GetSecrets 817.217µs 817.217µs 817.217µs 1 0
POST http://localhost:8080/server.Runner/GetVersion 786.916µs 786.916µs 786.916µs 1 0
POST http://localhost:8080/server.Runner/ListCodeGenerator 774.416µs 774.416µs 774.416µs 1 0
POST http://localhost:8080/server.Runner/ListConverter 734.815µs 734.815µs 734.815µs 1 0
tRPC Hello 452.51µs 452.51µs 452.51µs 1 1

Copy link

codacy-production bot commented Nov 11, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.11% 65.38%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b8bf7ff) 6426 5557 86.48%
Head commit (e9737f1) 6468 (+42) 5586 (+29) 86.36% (-0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#269) 78 51 65.38%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@LinuxSuRen LinuxSuRen force-pushed the feat/readonly-ext branch 7 times, most recently from f4257d2 to e9737f1 Compare November 11, 2023 22:31
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LinuxSuRen LinuxSuRen merged commit af92ea6 into master Nov 11, 2023
@LinuxSuRen LinuxSuRen deleted the feat/readonly-ext branch November 11, 2023 23:31
LinuxSuRen added a commit that referenced this pull request Nov 13, 2023
LinuxSuRen added a commit that referenced this pull request Nov 13, 2023
LinuxSuRen added a commit that referenced this pull request Nov 13, 2023
LinuxSuRen added a commit that referenced this pull request Nov 13, 2023
LinuxSuRen added a commit that referenced this pull request Nov 14, 2023
LinuxSuRen added a commit that referenced this pull request Nov 14, 2023
LinuxSuRen added a commit that referenced this pull request Nov 14, 2023
LinuxSuRen added a commit that referenced this pull request Nov 14, 2023
@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Nov 26, 2023
LinuxSuRen pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant