-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to generate grpc payload as JSON #264
Conversation
There are 21 test cases:
|
for _, f := range archive.File { | ||
if f.FileInfo().IsDir() { | ||
continue | ||
} | ||
|
||
targetFilePath := filepath.Join(targetDir, f.Name) | ||
if err = os.MkdirAll(filepath.Dir(targetFilePath), os.ModePerm); err != nil { | ||
return | ||
} | ||
|
||
var targetFile *os.File | ||
if targetFile, err = os.OpenFile(targetFilePath, | ||
os.O_CREATE|os.O_RDWR, f.Mode()); err != nil { | ||
continue | ||
} | ||
|
||
var fileInArchive io.ReadCloser | ||
fileInArchive, err = f.Open() | ||
if err != nil { | ||
continue | ||
} | ||
|
||
_, err = io.Copy(targetFile, fileInArchive) | ||
_ = targetFile.Close() | ||
} |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip")
3f9249b
to
e04cf0d
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
* chore(deps): update adguard/adguardhome docker tag to v0.107.35 * Update app version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-action update-app-version <[email protected]>
No description provided.