fix: verify grpc expect body #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxSuRen
reviewed
Oct 7, 2023
pkg/runner/grpc_test.go
Outdated
| Body: "{}", | ||
| }, | ||
| Expect: atest.Response{ | ||
| Body: getJSONOrCache("unaryneq", &testsrv.HelloReply{ |
There was a problem hiding this comment.
Actually, I didn't quite understand why using getJSONOrCache. I guess you only want to convert a struct into JSON string. A cached function might return an unpredictable result.
There was a problem hiding this comment.
ok i will do a bypass here
LinuxSuRen
reviewed
Oct 8, 2023
Signed-off-by: Ink33 <[email protected]>
Signed-off-by: Ink33 <[email protected]>
LinuxSuRen
force-pushed
the
fix_compare
branch
from
b648a24
to
87982ae
Compare
LinuxSuRen
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
|
The previous error caused by the Go version. Some third-pary library need 1.19. So I just upgrade it to. The current error caused by the GitHub Action secret cannot be accessed. |
LinuxSuRen
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix always pass when verify grpc expect body