Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logger #388

Closed
yuluo-yx opened this issue Apr 21, 2024 · 2 comments
Closed

feat: add logger #388

yuluo-yx opened this issue Apr 21, 2024 · 2 comments
Labels
enhancement New feature or request legend The contributions before they become a committer

Comments

@yuluo-yx
Copy link
Collaborator

Description:

replace project log.
such as

api-testing/cmd/server.go

Line 231 in c17b3e7

log.Printf("gRPC server listening at %v", lis.Addr())

Better performance with zap log, being used by more people

[optional Relevant Links:]

  1. https://pkg.go.dev/go.uber.org/zap
  2. https://github.com/uber-go/zap?tab=readme-ov-file#performance
@yuluo-yx yuluo-yx added the enhancement New feature or request label Apr 21, 2024
@LinuxSuRen
Copy link
Owner

Yes, the log part needs to improve.

@yuluo-yx yuluo-yx mentioned this issue Apr 21, 2024
Merged
@yuluo-yx
Copy link
Collaborator Author

completed, closed!

@LinuxSuRen LinuxSuRen added the legend The contributions before they become a committer label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request legend The contributions before they become a committer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinuxSuRen @yuluo-yx