Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sort=none on the search API #3476

Open
lmsurpre opened this issue Mar 16, 2022 · 1 comment
Open

Support sort=none on the search API #3476

lmsurpre opened this issue Mar 16, 2022 · 1 comment
Labels
enhancement New feature or request P3 Priority 3 - Nice To Have performance performance

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Mar 16, 2022

Is your feature request related to a problem? Please describe.
As part of #2026 we added support for thee sort options in the history api:

  • _lastUpdated
  • -_lastUpdated
  • none

The 'none' option is interesting because it gives us a neat way to sort via the primary key in the db which has some nice benefits for performance and paging consistency.

Describe the solution you'd like
Add support for sort=none on the search API.

Describe alternatives you've considered

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
if this goes well, I'd possibly even consider it to become the default sort...

@lmsurpre
Copy link
Member Author

This could be a good opportunity to add a new search paging mechanism without breaking the existing behavior.
Options:
A. do paging similar to our history API (with afterHistoryId=123 instead of _page=2 and only going forward in time)
B. write out all the resource ids that match the query at a given point in time (up to some limit)

@lmsurpre lmsurpre added the P3 Priority 3 - Nice To Have label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 Priority 3 - Nice To Have performance performance
Projects
None yet
Development

No branches or pull requests

1 participant