Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new architecture #38

Open
matinzd opened this issue May 18, 2022 · 2 comments · May be fixed by #59
Open

Migrate to new architecture #38

matinzd opened this issue May 18, 2022 · 2 comments · May be fixed by #59

Comments

@matinzd
Copy link

matinzd commented May 18, 2022

I think it's a good idea to use the native c++ implementation and migrate the whole boilerplate to use JSI. Any comments?

@LinusU
Copy link
Owner

LinusU commented May 29, 2022

I'm very open to considering this, but I would like to read up on it to understand all the implications of this first. Do you have any good pointers to find documentation on this?

@zolbooo
Copy link

zolbooo commented Jun 7, 2022

Official docs of next version of RN (0.69.0) seem to be a great place to start. I would like to help you with migration to new architecture, is there anything to help you out?

mateusz1913 added a commit to mateusz1913/react-native-get-random-values that referenced this issue Mar 24, 2024
- create JS Codegen spec
- use install_modules_dependencies util in podspec if possible, to install React deps
- migrate Android module class to conform to codegenerated spec when new arch enabled
- copy codegen-ed to oldarch Android source set to make module work when new arch disabled
- migrate iOS module class to conform to codegenerated spec when new arch enabled
@mateusz1913 mateusz1913 linked a pull request Mar 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants