Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load components made for older (or newer) componentsjs versions #73

Open
rubensworks opened this issue Feb 18, 2022 · 1 comment
Open

Don't load components made for older (or newer) componentsjs versions #73

rubensworks opened this issue Feb 18, 2022 · 1 comment
Labels
feature ➕

Comments

@rubensworks
Copy link
Member

rubensworks commented Feb 18, 2022 •
edited
Loading

Issue type:

  • ➕ Feature request

Description:

Currently, componentsjs can crash when it encounters components created for an older (major) version of componentsjs.
We should somehow detect the componentsjs version of these components, and only load them if they are supported.

This may require annotating modules with their supported componentsjs version. But it could also be done by detecting the imported context URL.
@github-actions
Copy link

Thanks for the suggestion!

@rubensworks rubensworks changed the title Don't load components made for older componentsjs versions Don't load components made for older (or newer) componentsjs versions Mar 8, 2022
@joachimvh joachimvh mentioned this issue Mar 8, 2022
Closed
@RubenVerborgh RubenVerborgh mentioned this issue Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ➕
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubensworks