Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moirai doesn't check return code from atropos, always returns 0 #8

Open
srikanth-viswanathan opened this issue Oct 16, 2015 · 1 comment
Open

moirai doesn't check return code from atropos, always returns 0 #8

srikanth-viswanathan opened this issue Oct 16, 2015 · 1 comment

Comments

@srikanth-viswanathan
Copy link

moirai should have a way to check whether the atropos job launched via multiprocessing.Process exited cleanly. Right now it only calls proc.join(). This results in moirai (and simoorg overall) returning 0 always, regardless of whether the individual atropos instances ran successfully to completion. Happy to work on patch. Let me know
@sarathsreedharan
Copy link
Contributor

Hey Srikanth,
That idea sounds great, Feel free to send a pull request once you have a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarathsreedharan @srikanth-viswanathan