Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of plugin paths #5

Open
srikanth-viswanathan opened this issue Sep 29, 2015 · 4 comments
Open

Allow overriding of plugin paths #5

srikanth-viswanathan opened this issue Sep 29, 2015 · 4 comments

Comments

@srikanth-viswanathan
Copy link

Currently the plugin paths are hardcoded in the python code. The deployment location of custom plugins might be different than the deployment location of simoorg, so it would be nice to allow the plugin paths to be overriden. My suggested way of doing this would be to add an optional parameter in the fate book to control the search location for plugins:

plugin_base_path: /my/custom/plugin/deployment/location
topology_plugin: MyTopologyPlugin

Currently, I have it working by starting simoorg inside my custom startup script where I override the relevant atropos.*_PLUGIN_PATH global variable, but I'd rather not do this if simoorg supported custom plugin paths out of the box.

@MayureshGharat
Copy link
Contributor

Sounds reasonable to do.

@MayureshGharat
Copy link
Contributor

Good to work on it. Feel free to submit a PR when done :)

@MayureshGharat
Copy link
Contributor

Hey @srikanth-viswanathan, Just wanted to see if you are actively working on the current issues that you raised with Simoorg. they seem to be really nice suggestions. Let me know :)

@srikanth-viswanathan
Copy link
Author

Haven't had time to work on these yet. I hope to do a couple next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants