Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation() gives up too easily #618

Closed
CommonClimate opened this issue Oct 14, 2024 · 0 comments
Closed

Correlation() gives up too easily #618

CommonClimate opened this issue Oct 14, 2024 · 0 comments
Assignees

Comments

@CommonClimate
Copy link
Collaborator

It's a tough world out there, and sometimes we need to compute hundreds of correlations at once.
We can't have Series.correlation() error out with a whimper if it can't find any overlap between Series X and Y. It needs to put on its big boy pants, return NaNs for r, p and signif=None, so that if we run MultipleSeries over a large MultipleGeoSeries object, one faulty dyad won't doom the whole thing. I'll allow it to whine a warning, though.

Context: currently using Pyleoclim to filter records in a large database of > 650 records for PReSto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant