Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fmin and fmax to freq_vector_log() #486

Closed
neillinehan opened this issue Dec 22, 2023 · 2 comments
Closed

Add fmin and fmax to freq_vector_log() #486

neillinehan opened this issue Dec 22, 2023 · 2 comments

Comments

@neillinehan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to examine specific scale ranges with wavelet coherence, tuning the minimum and maximum frequencies can allow more fine analysis, reducing unnecessary computation, especially with the wwz method.

Describe the solution you'd like
Add fmin and fmax to allowed arguments for freq_vector_log(), and the others.

@CommonClimate
Copy link
Collaborator

Hi @neillinehan,
I've implemented this feature and the custom ntau/tau, and tested both in a Jupyter Notebook. It works and it's actually a nice addition to our bag of tricks, so thank you for suggesting it.
Please pull from the master branch and give it another try; if it works for you, please close the issue.
Best,
Julien

@CommonClimate
Copy link
Collaborator

Closing this now since I have not heard word from @neillinehan . Can be re-opened if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants