Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't de-optimize @b lit where lit is a literal constant. #21

Closed
wants to merge 7 commits into from

Conversation

LilithHafner
Copy link
Owner

@LilithHafner LilithHafner commented Feb 24, 2024

Makes @b 1+1 and @b 2 equivalent.

It's unclear if this is worth doing.

@LilithHafner LilithHafner changed the title Remove buggy create_first_function Never apply create_first_function compilation time optimizations to the primary argument Feb 24, 2024
@LilithHafner LilithHafner changed the title Never apply create_first_function compilation time optimizations to the primary argument Don't de-optimize @b lit where lit is a literal constant. Feb 24, 2024
@LilithHafner
Copy link
Owner Author

But who actually cares if the runtime of 1 is overestimated by .5ns?

@LilithHafner
Copy link
Owner Author

This PR, while in need of rebase, is still a great starting point if we ever do want to do this. That said, I'm going to leave it closed unless folks actually want this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant