This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
Add DataClass Hydra Support #40
Labels
Comments
Choice 2 recap:
So looks like we'll have to marry DictConfig or scrap Hydra... |
I've seen a few repos that have Hydra in place: https://github.com/facebookresearch/mmf That might be a good place to have a look as to how things have been integrated there as well |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
OmegaConf 2.1 can now convert the config to real dataclasses: https://omegaconf.readthedocs.io/en/latest/usage.html#omegaconf-to-object |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Related #37
The final piece is to add automatic defaults + type checking for dataclasses.
Two options:
_name_
within the config to automatically convert to a specific data-class, go through the tree recursivelyChoice 1 is closer to Hydra, Choice 2 is better because we actually pass data-classes around.
The text was updated successfully, but these errors were encountered: