-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add normalizer, tokenizer to rouge #838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stancld mind help with adding relevant tests? :)
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 167 167
Lines 6904 6906 +2
=====================================
- Hits 6562 6553 -9
- Misses 342 353 +11 |
@stancld how is it going here? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hookSSi Thanks a lot for your contribution. I left a few minor comments but, in general, I think the PR looks quite good.
Regarding the tests.. I think we can just test default behaviour against the scenario we input the default tokenizer and normalizer manually into the module/functional metric and just verify everything goes through without problems. :]
I added test that just checking value. Have a look and review me please. |
@hookSSi could you please mark addressed comments as resolved so we easily see what has been left? 🐰 |
Oh I didn't know that I can mark these sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks
What does this PR do?
Fixes #825
I wrote some code but I don't know how to test it sorry.
plz review me hard
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃