-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple aggregation metrics #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 134 134
Lines 4809 4873 +64
=====================================
+ Hits 4568 4632 +64
Misses 241 241 |
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
ananyahjha93,
Borda,
edenlightning,
ethanwharris,
justusschock,
SeanNaren and
tchaton
as code owners
September 8, 2021 14:27
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
SkafteNicki
commented
Sep 30, 2021
Borda
reviewed
Sep 30, 2021
@SkafteNicki does it also addresses #49? |
for more information, see https://pre-commit.ci
tchaton
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #505
Introduces a couple of simple aggregation metrics for aggregating simple streams of values.
As
self.log
in lightning do not accept user definedreduce_fx
, it would be great if torchmetrics can supply some simple metrics for aggregating data. This PR implementsMeanMetric
(updated version ofAverageMeter
),SumMetric
,MinMetric
,MaxMetric
andCatMetric
that importantly also can deal withnan
values (what started the issue).PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃