Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Retrieval AUROC #2251

Merged
merged 21 commits into from
Dec 22, 2023
Merged

New metric: Retrieval AUROC #2251

merged 21 commits into from
Dec 22, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Dec 1, 2023

What does this PR do?

Fixes #2186

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2251.org.readthedocs.build/en/2251/

@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Dec 1, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Retrieval labels Dec 1, 2023
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, let's check the failing tests...

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #2251 (d95ed39) into master (7543641) will decrease coverage by 52%.
The diff coverage is 93%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2251     +/-   ##
========================================
- Coverage      87%     35%    -52%     
========================================
  Files         300     302      +2     
  Lines       16971   17015     +44     
========================================
- Hits        14737    5935   -8802     
- Misses       2234   11080   +8846     

@mergify mergify bot removed the has conflicts label Dec 22, 2023
@Borda Borda enabled auto-merge (squash) December 22, 2023 20:41
@Borda Borda merged commit 28025c1 into master Dec 22, 2023
60 checks passed
@Borda Borda deleted the newmetric/retrieval_auroc branch December 22, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Retrieval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUROC for Retrieval (i.e. AUROC with indexes support)
3 participants