-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutual Information Score #2008
Mutual Information Score #2008
Conversation
…san/metrics into 2003-mutual-info-score
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is already looking very good. I think we just need a bit of refactoring, because this introduces some functions that can benefit other clustering metrics.
for more information, see https://pre-commit.ci
…san/metrics into 2003-mutual-info-score
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
…san/metrics into 2003-mutual-info-score
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @matsumotosan.
Just fixes two smaller issues, but PR LGTM :]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2008 +/- ##
========================================
- Coverage 87% 35% -52%
========================================
Files 270 275 +5
Lines 15572 15649 +77
========================================
- Hits 13475 5469 -8006
- Misses 2097 10180 +8083 |
Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2008.org.readthedocs.build/en/2008/