Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on many detections in MeanAveragePrecision #1978

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 6, 2023

What does this PR do?

Fixes #1974

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1978.org.readthedocs.build/en/1978/

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #1978 (01bb81b) into master (e942f69) will decrease coverage by 48%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

❗ Current head 01bb81b differs from pull request most recent head ac3b757. Consider uploading reports for the commit ac3b757 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1978     +/-   ##
========================================
- Coverage      86%     39%    -48%     
========================================
  Files         266     266             
  Lines       15177   15185      +8     
========================================
- Hits        13123    5857   -7266     
- Misses       2054    9328   +7274     

@mergify mergify bot added the ready label Aug 6, 2023
@Borda Borda enabled auto-merge (squash) August 7, 2023 09:16
@Borda Borda disabled auto-merge August 7, 2023 09:20
@Borda Borda merged commit a4f67f3 into master Aug 7, 2023
@Borda Borda deleted the warning_on_many_detections branch August 7, 2023 09:20
@mergify mergify bot removed the ready label Aug 7, 2023
Borda pushed a commit that referenced this pull request Aug 8, 2023
Borda pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message if number of detections exceeds default max_detection_threshold settings.
3 participants