Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New metric: CLIP IQA #1931

Merged
merged 51 commits into from
Aug 21, 2023
Merged

New metric: CLIP IQA #1931

merged 51 commits into from
Aug 21, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 24, 2023 •
edited
Loading

What does this PR do?

Adds CLIPImageQualityAssessment as new metric to the image subpackage.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--1931.org.readthedocs.build/en/1931/

@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 28, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review July 31, 2023 12:15
@SkafteNicki
Copy link
Member Author

@lantiga thanks for the review. That is a really good point, so let me just move in to multimodal instead of image.

stancld
stancld reviewed Aug 19, 2023
View reviewed changes
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments. Looks good! Thanks for this addition! 🚀

@mergify mergify bot removed the has conflicts label Aug 21, 2023
@Borda Borda requested a review from stancld August 21, 2023 07:53
@Borda Borda enabled auto-merge (squash) August 21, 2023 07:54
@mergify mergify bot added the ready label Aug 21, 2023
@Borda Borda merged commit 29f3289 into master Aug 21, 2023
@Borda Borda deleted the newmetric/clip_iqa branch August 21, 2023 08:24
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Aug 25, 2023
@SkafteNicki @stancld
@pre-commit-ci @matsumotosan
New metric: CLIP IQA (Lightning-AI#1931)
bfe8e34 
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga lantiga approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@stancld stancld Awaiting requested review from stancld stancld is a code owner

Assignees
No one assigned
Labels
New metric ready topic: Image
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SkafteNicki @lantiga @Borda @stancld