Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeanAveragePrecision box and segm at same time #1928

Merged
merged 26 commits into from
Aug 8, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 19, 2023

What does this PR do?

Fixes #1905

Make it possible to extract mean average precision for both box and segmentation input at the same time. This is a larger refactor of the internals of the map metric, but it should make it easier to add support for keypoint detection (#1361) in the future.

I am fairly confident that this does not break backwards compatibility in any way as all original tests are passing without any changes.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1928.org.readthedocs.build/en/1928/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jul 19, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 19, 2023
@vsuryamurthy
Copy link
Contributor

Perfect, thanks for this change!

@mergify mergify bot removed the has conflicts label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1928 (d5b9080) into master (6aa6183) will decrease coverage by 48%.
Report is 1 commits behind head on master.
The diff coverage is 95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1928     +/-   ##
========================================
- Coverage      86%     39%    -48%     
========================================
  Files         266     266             
  Lines       15205   15280     +75     
========================================
- Hits        13148    5941   -7207     
- Misses       2057    9339   +7282     

@mergify mergify bot removed the has conflicts label Jul 28, 2023
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/helpers.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/mean_ap.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/mean_ap.py Outdated Show resolved Hide resolved
src/torchmetrics/detection/mean_ap.py Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Aug 3, 2023
@mergify mergify bot removed the has conflicts label Aug 5, 2023
@mergify mergify bot added the has conflicts label Aug 7, 2023
@Borda Borda requested review from Borda and vsuryamurthy August 7, 2023 13:20
@mergify mergify bot removed the has conflicts label Aug 7, 2023
src/torchmetrics/detection/mean_ap.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Aug 8, 2023
@Borda Borda enabled auto-merge (squash) August 8, 2023 07:10
@mergify mergify bot added the has conflicts label Aug 8, 2023
@Borda
Copy link
Member

Borda commented Aug 8, 2023

@SkafteNicki, mind checking the collision withe the prefix PR? 🦩

@mergify mergify bot removed the has conflicts label Aug 8, 2023
@Borda Borda merged commit 5d977e9 into master Aug 8, 2023
@Borda Borda deleted the feature/box_segm_at_same_time branch August 8, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the mean average precision of both bbox and segm simultaneously in one run
4 participants