Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classwise computation in IoU metric #1924

Merged
merged 22 commits into from
Aug 28, 2023
Merged

Fix classwise computation in IoU metric #1924

merged 22 commits into from
Aug 28, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 17, 2023

What does this PR do?

Fixes #1921
Became a larger refactor of this set of metric than first intended:

  • Some of the logic needed to be reworked to fix the issue
  • Move all testing to a single file because the metrics are so similar
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1924.org.readthedocs.build/en/1924/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jul 17, 2023
@SkafteNicki SkafteNicki added this to the v1.0.x milestone Jul 17, 2023
@Borda
Copy link
Member

Borda commented Aug 7, 2023

@SkafteNicki how is it going here? 🐰

CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda modified the milestones: v1.0.x, v1.1.x Aug 24, 2023
@SkafteNicki SkafteNicki added the refactoring refactoring and code health label Aug 25, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review August 25, 2023 12:47
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1924 (22b31af) into master (cc6f6cc) will decrease coverage by 48%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1924     +/-   ##
========================================
- Coverage      87%     38%    -48%     
========================================
  Files         275     275             
  Lines       15664   15650     -14     
========================================
- Hits        13563    5980   -7583     
- Misses       2101    9670   +7569     

@Borda
Copy link
Member

Borda commented Aug 27, 2023

@SkafteNicki seems we would need to find around for the oldest PyTorch:
ImportError: cannot import name 'complete_box_iou' from 'torchvision.ops'
Do you know from which version this function is present?

@Borda Borda enabled auto-merge (squash) August 28, 2023 10:18
@mergify mergify bot removed the has conflicts label Aug 28, 2023
@mergify mergify bot added the ready label Aug 28, 2023
@Borda Borda merged commit eeb40e9 into master Aug 28, 2023
@Borda Borda deleted the bugfix/iou branch August 28, 2023 13:21
Borda pushed a commit that referenced this pull request Aug 28, 2023
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit eeb40e9)
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intersection over union not respecting class labels
3 participants