Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pre and postfix for Classwise Wrapper #1866

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Implement pre and postfix for Classwise Wrapper #1866

merged 9 commits into from
Jul 4, 2023

Conversation

relativityhd
Copy link
Contributor

@relativityhd relativityhd commented Jun 29, 2023 •
edited by SkafteNicki
Loading

What does this PR do?

Fixes #1867
Adds two new parameter to the ClasswiseWrapper class to change the naming behaviour of it's outputs.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yessss 🙃

📚 Documentation preview 📚: https://torchmetrics--1866.org.readthedocs.build/en/1866/

@relativityhd relativityhd mentioned this pull request Jun 29, 2023
Closed
@SkafteNicki SkafteNicki added the enhancement New feature or request label Jul 4, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 4, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review July 4, 2023 08:38
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #1866 (fba600f) into master (8c5fab8) will decrease coverage by 45%.
The diff coverage is 100%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #1866     +/-   ##
========================================
- Coverage      85%     40%    -45%     
========================================
  Files         260     260             
  Lines       14908   14918     +10     
========================================
- Hits        12657    5984   -6673     
- Misses       2251    8934   +6683

Borda
Borda approved these changes Jul 4, 2023
View reviewed changes
src/torchmetrics/wrappers/classwise.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jul 4, 2023
@Borda Borda enabled auto-merge (squash) July 4, 2023 12:04
@Borda Borda merged commit d9f7c35 into Lightning-AI:master Jul 4, 2023
@anivegesana anivegesana mentioned this pull request Jul 12, 2023
Closed
@SkafteNicki SkafteNicki mentioned this pull request Jul 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stancld stancld stancld approved these changes

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Implement pre and postfix for Classwise Wrapper
4 participants
@relativityhd @Borda @stancld @SkafteNicki