Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports: deprecate from pkg root [3/n] Image #1696

Merged
merged 8 commits into from
Apr 11, 2023
Merged

imports: deprecate from pkg root [3/n] Image #1696

merged 8 commits into from
Apr 11, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 7, 2023

What does this PR do?

Part of #1681 (comment)

  • class version
  • functional
  • tests
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Apr 7, 2023
@Borda Borda requested a review from a team April 7, 2023 06:33
@Borda Borda enabled auto-merge (squash) April 7, 2023 06:37
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #1696 (53f96c3) into master (60e4177) will decrease coverage by 46%.
The diff coverage is 78%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1696     +/-   ##
========================================
- Coverage      89%     42%    -46%     
========================================
  Files         230     232      +2     
  Lines       12870   12985    +115     
========================================
- Hits        11407    5489   -5918     
- Misses       1463    7496   +6033     

@mergify mergify bot added the ready label Apr 8, 2023
@Borda Borda disabled auto-merge April 11, 2023 12:56
@mergify mergify bot removed the has conflicts label Apr 11, 2023
@Borda Borda enabled auto-merge (squash) April 11, 2023 13:00
@Borda Borda merged commit 1056c26 into master Apr 11, 2023
@Borda Borda deleted the imports/image branch April 11, 2023 14:15
@Borda Borda added this to the v1.0.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants