-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mypy from 0.982 to 1.0.0 in /requirements #1516
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
=======================================
+ Coverage 87% 89% +2%
=======================================
Files 216 216
Lines 11241 11183 -58
=======================================
+ Hits 9803 10003 +200
+ Misses 1438 1180 -258 |
Bumps [mypy](https://github.com/python/mypy) from 0.982 to 1.0.0. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.982...v1.0.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
bc7cfd6
to
2857423
Compare
@Borda Some typing needs to be fixed. Can it be fixed in a single commit and push it to this MR? Or we can disable |
@stancld feel free to just push the changes here. Personally, I like the |
@justusschock Agree, I like |
Mmm, will need to have another look as CI looks unhappy even though locally I get:
But that might be caused by the fact I'm using |
A newer version of mypy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
…ub.com/PyTorchLightning/metrics into dependabot-pip-requirements-mypy-1.0.0
Bumps mypy from 0.982 to 1.0.0.
Commits
bc18017
Promote 1.0.0+dev to 1.0.0 (#14594)c2876bf
[1.0 backport] [used before def] add documentation (#14592) (#14597)8ef98cc
Various documentation and error message tweaks (#14574)9aa1776
Improve Generics docs page (#14587)cb2ec3d
Improve protocols documentation (#14577)2cfc46c
Improve the Common Issues page (#14581)7cf1391
Make a top-level TypedDict page (#14584)dd2c9a6
Improve some dynamic typing docs (#14576)a6dce84
Upgrade to tox v4 (#14579)eb2e02d
Fix passenv for tox 4 (#14578)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)