Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 0.982 to 1.0.0 in /requirements #1516

Merged
merged 31 commits into from
Feb 22, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 17, 2023

Bumps mypy from 0.982 to 1.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the test / CI testing or CI label Feb 17, 2023
@dependabot dependabot bot requested a review from a team February 17, 2023 10:54
@Borda Borda enabled auto-merge (squash) February 17, 2023 11:04
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1516 (2857423) into master (6c3e1a5) will increase coverage by 2%.
The diff coverage is n/a.

❗ Current head 2857423 differs from pull request most recent head fe027f8. Consider uploading reports for the commit fe027f8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1516    +/-   ##
=======================================
+ Coverage      87%     89%    +2%     
=======================================
  Files         216     216            
  Lines       11241   11183    -58     
=======================================
+ Hits         9803   10003   +200     
+ Misses       1438    1180   -258     

@mergify mergify bot added the ready label Feb 17, 2023
Bumps [mypy](https://github.com/python/mypy) from 0.982 to 1.0.0.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.982...v1.0.0)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-mypy-1.0.0 branch from bc7cfd6 to 2857423 Compare February 17, 2023 13:08
@mergify mergify bot removed the ready label Feb 17, 2023
@stancld
Copy link
Contributor

stancld commented Feb 17, 2023

@Borda Some typing needs to be fixed. Can it be fixed in a single commit and push it to this MR?

Or we can disable PEP 484 (which causes an issue) -- prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

@justusschock
Copy link
Member

@stancld feel free to just push the changes here.

Personally, I like the no_implicit_optional=True change :)

@stancld
Copy link
Contributor

stancld commented Feb 17, 2023

@justusschock Agree, I like PEP 484 as well. I'll have a look and push the changes to this branch then :]

@stancld
Copy link
Contributor

stancld commented Feb 17, 2023

Mmm, will need to have another look as CI looks unhappy even though locally I get:

Success: no issues found in 216 source files

But that might be caused by the fact I'm using python 3.10.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 21, 2023

A newer version of mypy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Borda Borda self-assigned this Feb 21, 2023
@mergify mergify bot removed the has conflicts label Feb 22, 2023
@Borda Borda disabled auto-merge February 22, 2023 17:28
@Borda Borda merged commit 596cc4c into master Feb 22, 2023
@Borda Borda deleted the dependabot-pip-requirements-mypy-1.0.0 branch February 22, 2023 17:29
@mergify mergify bot added the ready label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants