Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken clone method for classification metrics #1250

Merged
merged 9 commits into from
Oct 6, 2022
Merged

Fix broken clone method for classification metrics #1250

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2784439
fix clone method
SkafteNicki Oct 5, 2022
54a10ed
Merge branch 'master' into bugfix/broken_cloning
SkafteNicki Oct 5, 2022
f8a68ad
Merge branch 'master' into bugfix/broken_cloning
Borda Oct 5, 2022
7de1c59
Merge branch 'master' into bugfix/broken_cloning
mergify[bot] Oct 5, 2022
5239c3f
chlog
Borda Oct 5, 2022
c3eb5bb
Merge branch 'bugfix/broken_cloning' of https://github.com/PyTorchLig…
Borda Oct 5, 2022
6d0f0f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2022
aae424f
typing
SkafteNicki Oct 6, 2022
b567ac8
Merge branch 'bugfix/broken_cloning' of https://github.com/PyTorchLig…
SkafteNicki Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/torchmetrics/metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,9 @@ def __pos__(self) -> "Metric":
def __getitem__(self, idx: int) -> "Metric":
return CompositionalMetric(lambda x: x[idx], self, None)

def __getnewargs__(self):
return (Metric.__str__(self),)


def _neg(x: Tensor) -> Tensor:
return -torch.abs(x)
Expand Down
5 changes: 5 additions & 0 deletions tests/unittests/helpers/testers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,11 @@ def _class_test(
if check_scriptable:
torch.jit.script(metric)

# check that metric can be cloned
clone = metric.clone()
assert clone is not metric, "Clone is not a different object than the metric"
assert type(clone) == type(metric), "Type of clone did not match metric type"

# move to device
metric = metric.to(device)
preds = apply_to_collection(preds, Tensor, lambda x: x.to(device))
Expand Down