From 5fb184d6502168bf52c116e99c1c3232330a3837 Mon Sep 17 00:00:00 2001 From: Skaftenicki Date: Wed, 4 May 2022 11:38:40 +0200 Subject: [PATCH] remove --- CHANGELOG.md | 3 +++ torchmetrics/detection/mean_ap.py | 9 +-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 044b2a72cba..b628f05f625 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -55,6 +55,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed deprecated `compute_on_step` argument in aggregation ([#990](https://github.com/PyTorchLightning/metrics/pull/990)) +- Removed deprecated `compute_on_step` argument in aggregation ([#1005](https://github.com/PyTorchLightning/metrics/pull/1005)) + + ### Fixed - Fixed multi device aggregation in `PearsonCorrCoef` ([#998](https://github.com/PyTorchLightning/metrics/pull/998)) diff --git a/torchmetrics/detection/mean_ap.py b/torchmetrics/detection/mean_ap.py index 8941ecf2c8b..4ed13944abc 100644 --- a/torchmetrics/detection/mean_ap.py +++ b/torchmetrics/detection/mean_ap.py @@ -168,12 +168,6 @@ class MeanAveragePrecision(Metric): Else, please provide a list of ints. class_metrics: Option to enable per-class metrics for mAP and mAR_100. Has a performance impact. - compute_on_step: - Forward only calls ``update()`` and returns None if this is set to False. - - .. deprecated:: v0.8 - Argument has no use anymore and will be removed v0.9. - kwargs: Additional keyword arguments, see :ref:`Metric kwargs` for more info. Example: @@ -231,10 +225,9 @@ def __init__( rec_thresholds: Optional[List[float]] = None, max_detection_thresholds: Optional[List[int]] = None, class_metrics: bool = False, - compute_on_step: Optional[bool] = None, **kwargs: Dict[str, Any], ) -> None: # type: ignore - super().__init__(compute_on_step=compute_on_step, **kwargs) + super().__init__(**kwargs) if not _TORCHVISION_GREATER_EQUAL_0_8: raise ModuleNotFoundError(