Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D SSIM #812

Closed
weningerleon opened this issue Jan 28, 2022 · 4 comments · Fixed by #818
Closed

3D SSIM #812

weningerleon opened this issue Jan 28, 2022 · 4 comments · Fixed by #818
Assignees
@justusschock @weningerleon
Labels
enhancement New feature or request help wanted Extra attention is needed New metric topic: Image
Milestone
v0.8

Comments

@weningerleon
Copy link
Contributor

weningerleon commented Jan 28, 2022 •
edited by Borda
Loading

The metrics StructuralSimilarityIndexMeasure and MultiScaleStructuralSimilarityIndexMeasure current only support 2D image data. A 3D version would be nice to have, and an extension to allow 3D data should be straightforward to implement. If you are interested in such an extension, I could take over the implementation.
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@Borda Borda added enhancement New feature or request help wanted Extra attention is needed New metric labels Jan 28, 2022
@Borda
Copy link
Member

Borda commented Jan 28, 2022

@weningerleon that would be a great addition, love to see your contributions! 🐰
cc: @SkafteNicki

@Borda Borda added this to the v0.8 milestone Jan 28, 2022
@justusschock
Copy link
Member

@weningerleon If you have a prototype, just open a PR and we can also see how we go there with testing

@weningerleon weningerleon mentioned this issue Jan 31, 2022
Merged
4 tasks
@weningerleon
Copy link
Contributor Author

Opened a PR. :)
The implementation produces sensible results on my data. If there's any standard way of testing please let me know. Once this gets green light, I'll have a look at MultiScaleStructuralSimilarityIndexMeasure.

@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justusschock justusschock

@weningerleon weningerleon

Labels
enhancement New feature or request help wanted Extra attention is needed New metric topic: Image
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

3D extension for SSIM weningerleon/metrics
3 participants
@Borda @justusschock @weningerleon